Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement OrderedFields cop #25

Merged

Conversation

kiskoza
Copy link
Contributor

@kiskoza kiskoza commented Oct 1, 2020

Hi. I saw #16 and I would like to add a cop to enforce alphabetical order for field definitions.

@DmitryTsepelev
Copy link
Owner

Hi @kiskoza! Looks good so far 👍

@kiskoza kiskoza force-pushed the alphabetical-order-for-fields branch from c57110f to 4e73123 Compare October 1, 2020 18:21
@kiskoza kiskoza marked this pull request as ready for review October 1, 2020 18:35
@kiskoza
Copy link
Contributor Author

kiskoza commented Oct 1, 2020

@DmitryTsepelev I'm ready with this PR, I hope we could merge it in soon.

@DmitryTsepelev
Copy link
Owner

LGTM, thank you so much!

@DmitryTsepelev DmitryTsepelev merged commit e1578ba into DmitryTsepelev:master Oct 2, 2020
kiskoza added a commit to kiskoza/rubocop-graphql that referenced this pull request Mar 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants