ExtractInputType: show all excess args in offense #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Clearly my pot shot edit through GH doesn't work 😆 happy to clone and do it the right way if you are open to a PR |
|
Hi @bessey, I'm definitely open to PRs and suggestions 🙂 |
|
I will look to get to this in my next sprint, FYI |
|
Does this look good to you now @DmitryTsepelev? |
I believe this makes it clearer what is wrong when introducing the cop to an existing code base, where a mutation may already have an excess of arguments. Otherwise, you delete an argument, the errors moves up a line, and so on until you get below MaxArguments.
|
LGTM, thank you so much! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe this makes it clearer what is wrong when introducing the cop to an existing code base, where a mutation may already have an excess of arguments.
Otherwise, you delete an argument, the errors moves up a line, and so on until you get below MaxArguments.
Just a draft for now with no spec improvements to confirm you're open to PRs! Happy to fix up anything that's broken, which may be everything haha.