New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[UnusedArgument] Respect :as keyword even without :loads #67

Merged

DmitryTsepelev merged 1 commit into DmitryTsepelev:master from nvasilevski:as-alias-can-be-used-without-loads

Jan 7, 2022

Contributor

nvasilevski commented Jan 5, 2022

One more tiny fix
:as keyword can be used without :loads so we need to always respect it if present
Conceptually the change is as tiny as:

-         if declared_arg.kwargs.loads.nil?
+         if declared_arg.kwargs.loads.nil? && declared_arg.kwargs.as.nil?
            declared_arg.name
          else
            declared_arg.as || inferred_arg_name(declared_arg.name.to_s)
          end

but I did a bit of refactoring :)


          [UnusedArgument] Respect :as keyword even without :loads

071d2be

DmitryTsepelev approved these changes

View reviewed changes

Owner

DmitryTsepelev left a comment

👍

DmitryTsepelev merged commit cbac873 into DmitryTsepelev:master

nvasilevski deleted the as-alias-can-be-used-without-loads branch

January 7, 2022 20:12

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet