Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ExtractType]: add has prefix to default values for config #89

Conversation

MH4GF
Copy link
Contributor

@MH4GF MH4GF commented Aug 2, 2022

Hey there! Thanks for publishing a great library!

I have disabled has prefix in our project(e.g. hasNextPage and hasPreviousPage ), and since it is often used as a generic naming convention. You can also find a number of them in the GitHub API.
This is a minor correction, but I thought it was acceptable to include it in the default prefixes.

@DmitryTsepelev
Copy link
Owner

Hi @MH4GF! Good point, thank you! 🙂

@DmitryTsepelev DmitryTsepelev merged commit da905cf into DmitryTsepelev:master Aug 2, 2022
@MH4GF MH4GF deleted the add-default-prefixes-for-extract-type branch August 2, 2022 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants