Added option to pass configs as args for all config files #12
Conversation
|
@DmitryTsepelev I think we should probably rename Please also have a look at the option naming and description I have decided to go with. |
|
Overall looks good 🙂
makes sense |
|
@DmitryTsepelev PR is ready for review. Please have a look. |
| p.on("--since=SINCE", "Specify date to start checking git history") do |since| | ||
| @since = since | ||
| end | ||
| p.on("--generate_config", "Generate default config based on .rubocop_todo.yml") |
There was a problem hiding this comment.
I'd rather keep - version everywhere (--generate-config instead of --generate_config)
There was a problem hiding this comment.
Hey, I did some testing when I decided to go with - instead which I forgot to mention.
hyphen (-) and underscore (_) can be used interchangeably when using them with OptionParser.
ie in this case, bundle exec rubocop-director --generate-config == bundle exec rubocop-director --generate_config
The only difference between them is that args containing a hyphen are parsed into :'generate-config' whereas args without them can be directly used as symbols :generate_config
I also have a question about ruby symbols that I think you can help me with.
I know that (1) :'abc' and (2) :abc both are symbols. Ideally, there should not be any difference bw them. But I try to never use the first kind. I have an assumption that in the case of (1), a string is getting converted into a symbol. whereas (2) itself is a symbol. Am I correct in making this assumption? Also, do share if you know of any differences.
It is kind of confusing so please let me know if it does not make sense.
Thanks!
There was a problem hiding this comment.
hyphen (-) and underscore (_) can be used interchangeably when using them with OptionParser.
ah I didn't know that
Am I correct in making this assumption? Also, do share if you know of any differences.
I think you're right about the conversion (but maybe it's done in the "compile" time when they are used as literals)
Fixes #6