This repository has been archived by the owner on Oct 29, 2020. It is now read-only.
Fix Forge 6.7 visual bugs. #6365
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
^ also just snuck a fix for #6364 in here too. 👟 |
Form and intro copy were too close. Added a `container__row` surrounding the form to give it the proper spacing!
|
And I added a bbda059 too for free! Value! 💸 |
DFurnes
changed the title
|
Looks good! sorry for the delay was out on personal time :) |
|
@sbsmith86 Np np! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's this PR do?
Fix overflow issue in Step 4 of the campaign template.
So this is happening because we switched container spacing to use margins rather than padding. On mobile, the container block's margin is collapsing and being lost outside the container... but on desktop, this doesn't happen because the
float: left;on the.container > .wrappercreates a new block formatting context.I think a good fix would be to add a universal
float: leftto all.container > .wrappers, regardless of breakpoint. It's a bit weird, but has less potential side effects than adding anoverflow: hiddenI think...How should this be manually tested?
Idk, look at things do they look nice? 👀
Any background context you want to provide?
Gah. CSS, am I right?
I'll update this in a Forge patch release too but wanted to get a PR up to unblock today's deploy!
What are the relevant tickets?
Fixes #6363. Fixes #6364.
For review: @DoSomething/front-end