Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing variants field to media #679

Merged
merged 7 commits into from
Dec 26, 2022
Merged

Add missing variants field to media #679

merged 7 commits into from
Dec 26, 2022

Conversation

igorbrigadir
Copy link
Contributor

Fix #678

Don't think we need a test for this one right? It's just adding a field that was missing.

@igorbrigadir
Copy link
Contributor Author

I might go through and quickly check in case there's other fields that should be added

@igorbrigadir
Copy link
Contributor Author

Finally fixed the tests... the issue was the black formatter https://pypi.org/project/black/23.1a1/#history has a pre release version, that setup.py prefers to install, while locally, pip only installs pre release versions with --pre.

The easier solution is to update your local black version to the latest pre-release:

pip install --upgrade --pre black

@edsu
Copy link
Member

edsu commented Dec 26, 2022

Yikes, thank you for catching that atest/test change. That looks like something I committed by mistake!

@edsu edsu merged commit b1fe166 into main Dec 26, 2022
@igorbrigadir igorbrigadir deleted the media-variants branch December 26, 2022 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing variants field in media.fields
2 participants