Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #109 #138

Merged
merged 1 commit into from
Oct 2, 2017
Merged

Fix #109 #138

merged 1 commit into from
Oct 2, 2017

Conversation

welwood08
Copy link
Contributor

Assumes directories won't have .proto suffix.

@welwood08 welwood08 mentioned this pull request Oct 2, 2017
Closed
@DoctorMcKay
Copy link
Owner

String.prototype.endsWith is not available before Node 6.5.0. Please use regex instead.

@welwood08
Fix DoctorMcKay#109
9d4812d 
Assumes directories won't have `.proto` suffix.
@welwood08
Copy link
Contributor Author

I also realised that might be the case, force pushed alternative.

@DoctorMcKay
Copy link
Owner

👍 Seems good to me. Thanks.

@DoctorMcKay DoctorMcKay merged commit 2bd3248 into DoctorMcKay:master Oct 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@welwood08 @DoctorMcKay