fix(markdown-serializer): Add custom rule to escape horizontal rules for rich-text #163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for doist-typist ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
|
A simpler and less hacky solution was implemented on the renderer side instead (ref). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
With #102 we overrode Turndown's escape mechanism with our custom implementation with custom rules to overcome the agressive rules built-in the default implementation. Before making this a permanent change, we tested the custom implementation in production for more than a month, and since no bugs were reported during that time, we decided to keep it. However, caused by this custom escape mechanism, we recently got our first bug report (ref). This PR fixes that issue by adding a custom rule to the custom escape mechanism.
PR Checklist
Test plan
The new custom rule is already fully tested by the added unit test, and unfortunately it's not possible to manually test this without making changes to the Storybook editor, which makes for a cumbersome test plan.