Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Empty list items returns incorrectly formatted Markdown #874

Merged
merged 1 commit into from
Aug 16, 2024
Merged

fix: Empty list items returns incorrectly formatted Markdown #874

merged 1 commit into from
Aug 16, 2024

Conversation

rfgamaral
Copy link
Member

Overview

This fixes an internal issue https://github.com/Doist/Issues/issues/14669 where empty list items (both for ordered and bullet lists) would return incorrectly formatted Markdown (see test plan below).

PR Checklist

Test plan

  • Open the preview Storybook deployed to Netlify
  • Open the Rich-text → Default story
  • Type -<space>One
  • Type <Enter>
  • Type Two
  • Insert an empty item between One and Two
    • Observe that the Markdown Output shows the expected Markdown

Demo

Before After
image image

@rfgamaral rfgamaral added the 👀 Show PR Used for PRs that need a review, but can be merged when CI is green. label Aug 16, 2024
@rfgamaral rfgamaral requested a review from a team August 16, 2024 19:26
@rfgamaral rfgamaral self-assigned this Aug 16, 2024
@rfgamaral rfgamaral requested review from Bloomca and removed request for a team August 16, 2024 19:26
@rfgamaral rfgamaral enabled auto-merge (squash) August 16, 2024 19:26
@netlify Netlify
Copy link

netlify bot commented Aug 16, 2024 •
edited
Loading

✅ Deploy Preview for doist-typist ready!

Name Link
🔨 Latest commit a50ae06
🔍 Latest deploy log https://app.netlify.com/sites/doist-typist/deploys/66bfa7f0b403c100085b7632
😎 Deploy Preview https://deploy-preview-874--doist-typist.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@rfgamaral rfgamaral merged commit 9c8bcb5 into main Aug 16, 2024
9 checks passed
@rfgamaral rfgamaral deleted the ricardo/fix-bullet-list-markdown branch August 16, 2024 19:30
doistbot added a commit that referenced this pull request Aug 16, 2024
@doistbot
chore(release): 6.0.8 [skip ci]
759a8a1 
## [6.0.8](v6.0.7...v6.0.8) (2024-08-16)

### Bug Fixes

* Empty list items returns incorrectly formatted Markdown ([#874](#874)) ([9c8bcb5](9c8bcb5))
@doistbot
Copy link
Member

🎉 This PR is included in version 6.0.8 🎉

The release is available on:

Your semantic-release bot 📦🚀

@doistbot doistbot added the released Pull requests that have been released to production label Aug 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Bloomca Bloomca Awaiting requested review from Bloomca Bloomca was automatically assigned from Doist/frontend-product

Assignees

@rfgamaral rfgamaral

Labels
released Pull requests that have been released to production 👀 Show PR Used for PRs that need a review, but can be merged when CI is green.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rfgamaral @doistbot