Added pull handles to JWT editor view #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes the view more useful on small screens or with large font sizes, since the user can focus on the token contents rather than the serialized view or signature hex dump
|
Thanks for the PR. It looks like a really nice improvement! Do you think that the JWE panel should have them as well? |
|
The top divider applies whichever tab is selected (the SplitPanel which provides it is a parent of the Tab panel). I saw no obvious place to put a divider inside the JWE tab, it seems more balanced (multiple similar fields) than the JWT panel (more commonly useful stuff followed by the large Signature field). I may have missed something, but placing two dividers in the JWE tab would (AFAICT) lead to a hierarchy of paired panels, which probably wouldn't behave as the user would expect. |
|
Fair enough 👍 I'll merge it now and email PortSwigger over the weekend to kick start getting it into the BAppStore. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the current version, the JWT editor is inflexible and hard to read on small screens or with larger font sizes.
This PR adds two pull handles to the JWT editor tab (as shown in Burp request/response views). The user can use these to vertically shrink the serialized text field and the signature hex view, to focus on the contents of the token.
Current cramped view:
More helpful view (note the pull handles between serial, tabview and signature):
