Upgrade deps #62
Open
Upgrade deps #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jontiritilli
approved these changes
Oct 2, 2024
| import { Manifest } from "ryuu-client/lib/models"; | ||
| import { Manifest as RCManifest } from "ryuu-client/lib/models"; | ||
|
|
||
| export type Manifest = RCManifest; |
There was a problem hiding this comment.
Does this intend to allow access to the manifest from apps in the future?
There was a problem hiding this comment.
It was actually a TS error since Manifest was not getting re-exported from here but referenced in another file. Either way, it should allow to re-use this library to import the interface, yes
There was a problem hiding this comment.
Oh, and actually, I might also open a patch PR for ryuu-client since the def for Manifest didn't seem accurate from what I saw
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As we're making changes to our apps' template to prepare to make those libraries public soon, I also added a small set of changes here to fix dependency vulnerabilities and tiny TS errors.
I couldn't find the branch for v4.4.0, so this PR targeting
mastermight be incorrect. If that's the case, could you point me to the correct branch/tag and I can rebase the changes?