Add coverage related comments

DotNetAnalyzers · Jul 2, 2023 · 58039b3 · 58039b3
1 parent 92d66c6
commit 58039b3
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 0 deletions.
diff --git a/StyleCop.Analyzers/StyleCop.Analyzers.Test/LayoutRules/SA1501UnitTests.cs b/StyleCop.Analyzers/StyleCop.Analyzers.Test/LayoutRules/SA1501UnitTests.cs
@@ -847,6 +847,9 @@ public void Bar(int i)
         [MemberData(nameof(TestStatements))]
         public async Task TestNoSA1503StatementWithBracesAsync(string statementText)
         {
+            // TODO: The statement in this test code does not have braces! Change test name or the code?
+            // There is uncovered code in SA1501 related to blocks when SA1503 is suppressed, so either
+            // change this to do what the the name says or change the name and add another test.
             await new CSharpTest
             {
                 TestCode = this.GenerateFixedTestStatement(statementText),

diff --git a/...p.Analyzers/StyleCop.Analyzers/MaintainabilityRules/SA1400AccessModifierMustBeDeclared.cs b/...p.Analyzers/StyleCop.Analyzers/MaintainabilityRules/SA1400AccessModifierMustBeDeclared.cs
@@ -91,6 +91,8 @@ private static void HandleEventDeclaration(SyntaxNodeAnalysisContext context)
 
             if (syntax.Parent.IsKind(SyntaxKind.InterfaceDeclaration))
             {
+                // NOTE: Events in interfaces seem to be reported as EventFieldDeclaration, so this should not happen.
+                // Leaving it for consistency and possible future changes though.
                 return;
             }