Update SA1009 to require a space after the closing parenthesis if it is followed by ++ or -- from a prefix unary expression #3750

bjornhellander · 2023-12-09T07:46:54Z

codecov · 2023-12-09T08:41:02Z

Codecov Report

Merging #3750 (63700b5) into master (be49652) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #3750   +/-   ##
=======================================
  Coverage   97.40%   97.40%           
=======================================
  Files         914      914           
  Lines      108762   108796   +34     
  Branches     3284     3284           
=======================================
+ Hits       105937   105971   +34     
  Misses       1847     1847           
  Partials      978      978

sharwell · 2023-12-15T14:14:08Z

...p.Analyzers/StyleCop.Analyzers/SpacingRules/SA1009ClosingParenthesisMustBeSpacedCorrectly.cs

+            case SyntaxKind.IfStatement:
+            case SyntaxKind.WhileStatement:
+            case SyntaxKind.ForStatement:
+            case SyntaxKind.ForEachStatement:
+                precedesStickyCharacter = false;
+                break;


💭 I think I would prefer this to be relocated to the handling of PlusPlusToken/MinusMinusToken above, and the new implementation in that section should be similar to the way PlusToken and MinusToken and handled further above.

Updated. Did you have something like that in mind?

…is followed by ++ or -- from a prefix unary expression DotNetAnalyzers#3731

sharwell reviewed Dec 15, 2023

View reviewed changes

bjornhellander force-pushed the feature/sa1009-if-one-liner branch 2 times, most recently from e641a23 to cd288a2 Compare December 15, 2023 16:54

Update SA1009 to require a space after the closing parenthesis if it …

63700b5

…is followed by ++ or -- from a prefix unary expression DotNetAnalyzers#3731

bjornhellander force-pushed the feature/sa1009-if-one-liner branch from cd288a2 to 63700b5 Compare December 17, 2023 07:19

bjornhellander changed the title ~~Update SA1009 to require a space after the closing parenthesis if is is followed by ++ or -- from a prefix unary expression~~ Update SA1009 to require a space after the closing parenthesis if it is followed by ++ or -- from a prefix unary expression Dec 17, 2023

sharwell approved these changes Dec 18, 2023

View reviewed changes

sharwell merged commit 4495405 into DotNetAnalyzers:master Dec 18, 2023
19 checks passed

sharwell added this to the 1.2-beta.next milestone Dec 18, 2023

bjornhellander deleted the feature/sa1009-if-one-liner branch December 19, 2023 19:28

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update SA1009 to require a space after the closing parenthesis if it is followed by ++ or -- from a prefix unary expression #3750

Update SA1009 to require a space after the closing parenthesis if it is followed by ++ or -- from a prefix unary expression #3750

bjornhellander commented Dec 9, 2023

codecov bot commented Dec 9, 2023 •

edited

Loading

sharwell Dec 15, 2023

bjornhellander Dec 15, 2023

Update SA1009 to require a space after the closing parenthesis if it is followed by ++ or -- from a prefix unary expression #3750

Update SA1009 to require a space after the closing parenthesis if it is followed by ++ or -- from a prefix unary expression #3750

Conversation

bjornhellander commented Dec 9, 2023

codecov bot commented Dec 9, 2023 • edited Loading

Codecov Report

sharwell Dec 15, 2023

Choose a reason for hiding this comment

bjornhellander Dec 15, 2023

Choose a reason for hiding this comment

codecov bot commented Dec 9, 2023 •

edited

Loading