Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP - DONT MERGE] Add EVERYTHING!!! #13

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jamestalmage
Copy link
Contributor

Mostly just expiremental at this point. Adds a whole bunch of options.

@jamestalmage
Copy link
Contributor Author

Features added:

  1. Code folding: arrows in the gutter allow you to fold whole sections of markdown / code.
  2. Tag and Brace Matching: If your cursor is near an opening / closing brace, that brace is highlighted bright green, as is it's companion. Same with html tags.
  3. Tag and Brace auto closing: If you type an opening brace / tag, the closing one is automatically added.
  4. Comment continuation: If you hit enter on a comment line, the next line is automatically a comment line (not sure I like this).
  5. List continuation: If you hit enter while in a list, the newline is automatically outdented to match. (I definitely like this).
  6. Show trailing space: (not working) - It should show trailing whitespace in the editor. I think I'm missing a CSS class.
  7. Search: Not sure this is worth it, seems to be pretty close to what CMD+F gives you in chrome anyways. It does have RegExp support, which is nice.
  8. Search and Replace: (not working) - It should give you search and replace.
  9. Keymap - Installs the sublime keymap: https://codemirror.net/demo/sublime.html
  10. Simple ScrollBar - Not sure it's worth it. Installed while trying to get 11 to work
  11. Search results on scrollbar: (not working) - show search result matches in the scrollbar.

@DrewML
Copy link
Owner

DrewML commented May 18, 2016

Nice! This is awesome! A few comments, where the number corresponds to your line item above:

  1. 👍
  2. 👍 👍
  3. 👍 👍 👍
  4. I've always disliked that in my editor. Good candidate for a setting in our options page
  5. 👍
  6. Won't use it personally, but another good candidate for being configurable
  7. I personally dislike search fields in text areas on a page, but I'm fine with it if it's configurable
  8. Indifferent
  9. 👍 👍 👍 Will use that frequently
  10. Isn't there already a scrollbar (just the native browser one)?
  11. Same as Add to the codemirror list of external projects #7, cool with including being a configuration flag

Going to hold off on a merge of this now, just because there are a few things I'd like to make sure start off being configurable. I'm pretty close to having the basics of options working, though, so we should be able to implement this soon.

@jamestalmage
Copy link
Contributor Author

Yeah, this was more an experiment in how to use codemirror.

@jamestalmage jamestalmage changed the title [WIP] Add EVERYTHING!!! [WIP - DONT MERGE] Add EVERYTHING!!! May 18, 2016
@DrewML
Copy link
Owner

DrewML commented May 27, 2016

I pushed an update to master/Chrome store that enables the brace/paren matching and auto-closing. Couldn't live without it :)

@jamestalmage
Copy link
Contributor Author

We need to figure out how to make it the default choice. I keep forgetting to use it.

@DrewML
Copy link
Owner

DrewML commented May 27, 2016

Agreed. My weekend is crazy, but I'm hoping to tackle that early next week.

@jamestalmage
Copy link
Contributor Author

We're blocked on that until we figure out @ popups, right?

@DrewML
Copy link
Owner

DrewML commented May 27, 2016

Yes and no. We're blocked on replacing the Write tab entirely while we don't have the @ popups. However, I'd like to add an option to set Code to the default for the time being. That way, you default to Code, but can use the hotkey to switch over to write when you need autofill for an @mention.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants