Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ic_launcher.png improved #1404

Merged
merged 4 commits into from
Feb 16, 2015
Merged

ic_launcher.png improved #1404

merged 4 commits into from
Feb 16, 2015

Conversation

zumbrunnen
Copy link
Member

While adressing dronekit/dronekit-android#7 I noticed two things:

So, I created a SVG version (in Inkscape) and updated the ic_launcher.pngs. It has a shadow below and a shadow dropping from the paper plane. Compare it to the "Downloads" icon on your handset and you'll spot the similarities.

comparison

If someone's intrested in the SVG version (or if this should be put under version control) - let me know.

If you think, Tower's icon (which is a paper plane... paper plane? tower? paper plane? 😁) has to be flat, kindly refuse this PR.

@zumbrunnen
Copy link
Member Author

WIP alert! 🐲 Please wait with processing this PR. I got more improvements.

Color changes to green when connected
@zumbrunnen
Copy link
Member Author

OK, now it's ready for a review. :shipit:

I've added customized status bar icons. They show the Tower icon better (instead of just a circle).

Further: When Tower is connected to the UAV, the notification icon's background changes to green.

Cross-check with dronekit/dronekit-android#54

@m4gr3d
Copy link
Member

m4gr3d commented Feb 16, 2015

@zumbrunnen the updated Tower icon looks great as well!!

Could you put the svg version under version control as well. It should go in the Android/art directory.

thanks for the awesome work!

- Hint: the ic_stat_notify icon might look empty, it's because its shape is white.
- Hi-Res icon (for Play Store) overwritten
- Old DP2 icon deleted
@zumbrunnen
Copy link
Member Author

@ne0fhyk Done!

m4gr3d added a commit that referenced this pull request Feb 16, 2015
@m4gr3d m4gr3d merged commit 906893a into DroidPlanner:master Feb 16, 2015
@zumbrunnen zumbrunnen deleted the ic_launcher_improved branch February 16, 2015 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants