todo cleanup

DuendeSoftware · Sep 22, 2022 · 51a2746 · 51a2746
1 parent f2cdd7d
commit 51a2746
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/src/Duende.AccessTokenManagement.OpenIdConnect/AuthenticationSessionUserTokenStore.cs b/src/Duende.AccessTokenManagement.OpenIdConnect/AuthenticationSessionUserTokenStore.cs
@@ -213,7 +213,7 @@ public Task ClearTokenAsync(
             ClaimsPrincipal user, 
             UserTokenRequestParameters? parameters = null)
         {
-            // todo
+            // don't bother here, since likely we're in the middle of signing out
             return Task.CompletedTask;
         }
 

diff --git a/src/Duende.AccessTokenManagement.OpenIdConnect/UserAccessTokenManagementService.cs b/src/Duende.AccessTokenManagement.OpenIdConnect/UserAccessTokenManagementService.cs
@@ -135,8 +135,10 @@ private async Task<UserToken> RefreshUserAccessTokenAsync(
     {
         var userToken = await _userAccessTokenStore.GetTokenAsync(user, parameters);
 
-        // todo: should not happen - should we use better exception?
-        ArgumentNullException.ThrowIfNull(userToken.RefreshToken);
+        if (String.IsNullOrWhiteSpace(userToken.RefreshToken))
+        {
+            throw new InvalidOperationException("No refresh token in store.");
+        }
 
         var refreshedToken =
             await _tokenEndpointService.RefreshAccessTokenAsync(userToken.RefreshToken, parameters, cancellationToken);