Update wilson and framework dependencies #92
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We want to match our requirements with the oidc handler in asp.net. As of today, the latest version is 8.0.3, which depends on wilson >= 7.1.2 https://www.nuget.org/packages/Microsoft.AspNetCore.Authentication.OpenIdConnect/8.0.3#dependencies-body-tab
6.0.26 of the asp.net packages was the first version to depend on wilson 6.35.0. We want wilson 6.35 because it contains security fixes. We don't depend on anything more recent than that, so we can keep our requirements as relaxed possible beyond that.
We take the earliest version that doesn't have a known security vulnerability, so we go with 8.0.1 to ensure that our transitive dependency on the wilson JWT library is at least 7.1.2.
IdentityServer depends on version 8.0.3 of the oidc auth handler, while we only use 8.0.1. This is normally fine, but if we explicitly take a dependency on both the handler at version 8.0.1 and identity server, then our explicit dependency is a downgrade of what identity server wants, producing a warning. We don't actually need the explicit dependency, and removing it fixes the build.
josephdecock
force-pushed
the
joe/dependencies
branch
from
538423a
to
efc4eda
Compare
brockallen
approved these changes
Apr 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This relaxes our dependencies on the wilson and framework dependencies.
Our priorities:
Also, while here I'm updating the net6.0 build, we may (probably will) drop support for that in the 3.0 release.