Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use new clock abstraction #1341

Merged
merged 5 commits into from
Jul 7, 2023
Merged

Use new clock abstraction #1341

merged 5 commits into from
Jul 7, 2023

Conversation

brockallen
Copy link
Member

Given that the old ISystemClock has only second-level granularity, and that it is deprecated, this PR introduces a new clock abstraction. The default implementation is based on the new TimeProvider in .NET 8, but a legacy implementation is provided for those who still want the older ISystemClock behavior.

Closes: #949

@brockallen
Copy link
Member Author

brockallen commented Jun 22, 2023

pinging @kimayoi72 @BrianAlk for review/feedback, since you had opened issues in the past related to this.

@brockallen brockallen marked this pull request as ready for review June 22, 2023 16:47
@brockallen brockallen added this to the 7.0 milestone Jun 22, 2023
@josephdecock josephdecock merged commit 99b3748 into main Jul 7, 2023
5 checks passed
@josephdecock josephdecock deleted the brock/clock-work branch July 7, 2023 16:31
@josephdecock josephdecock mentioned this pull request Jul 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consider using something custom rather than ISystemClock
2 participants