Warn when non-distributed cache detected #1550
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josephdecock
reviewed
May 7, 2024
src/IdentityServer/Configuration/DependencyInjection/ConfigureOpenIdConnectOptions.cs
Outdated
Show resolved
Hide resolved
AndersAbel
force-pushed
the
anders/warn-non-distributed-cache
branch
from
937cca0
to
47728c4
Compare
AndersAbel
force-pushed
the
anders/warn-non-distributed-cache
branch
from
47728c4
to
9735889
Compare
|
Marking this as draft to keep it on hold until build issues in releases/7.0.x have been fixed. |
josephdecock
force-pushed
the
anders/warn-non-distributed-cache
branch
from
9735889
to
59738c9
Compare
|
The 7.0 release should be fixed now, yet the checks still failed? That was so weird that I rebased this branch to try again... |
|
Okay, not sure why a rebase was necessary, but it looks like the build works now. @AndersAbel - do we need this in a 7.0 patch release? |
|
@josephdecock I don't think we need a release just for this. I've had a couple of support cases caused by people running the OIDC Formatter with the in memory distributed cache. This will reduce the risk for people hitting that, but it can go with the next release. |
|
Can we mark this with label and milestone? |
AndersAbel
added
enhancement
AndersAbel
removed
the
no release notes needed
brockallen
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Log (info level) if OIDC state data formatter is enabled with in memory distributed cache.
I've had a few cases in support where the Oidc state data formatter has been enabled but the distributed cache is the default memory based version. IdentityServer (unfortunately?) adds the in memory implementation as a fallback so it is easy to miss this. A warning message similar to the ones we have for in memory persisted grants should help.