Corrected radar alt offset from wrong position

Dunbaratu · Jul 18, 2019 · baa363f · baa363f
1 parent 2b2c50c
commit baa363f
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 3 deletions.
diff --git a/src/kOS/Suffixed/BodyTarget.cs b/src/kOS/Suffixed/BodyTarget.cs
@@ -235,8 +235,7 @@ public ScalarValue AltitudeFromPosition(Vector position)
         /// <returns></returns>
         public ScalarValue RadarAltitudeFromPosition(Vector position)
         {
-            Vector3d unityWorldPosition = Shared.Vessel.CoMD + position.ToVector3D();
-            GeoCoordinates geo = GeoCoordinatesFromPosition(new Vector(unityWorldPosition));
+            GeoCoordinates geo = GeoCoordinatesFromPosition(position);
             ScalarValue terrainHeight = geo.GetTerrainAltitude();
             ScalarValue seaAlt = AltitudeFromPosition(position);
             if (Body.ocean && terrainHeight < 0)

diff --git a/src/kOS/Suffixed/BoundsValue.cs b/src/kOS/Suffixed/BoundsValue.cs
@@ -190,7 +190,6 @@ public double BottomAltitudeRadar()
         {
             BodyTarget body = BodyTarget.CreateOrGetExisting(shared.Vessel.mainBody, shared);
             Vector bottomInShipRaw = FurthestCorner(new Vector(-shared.Vessel.upAxis));
-            GeoCoordinates geo = body.GeoCoordinatesFromPosition(bottomInShipRaw);
             return body.RadarAltitudeFromPosition(bottomInShipRaw);
         }