Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEATURE: Mounts Feeding Needs #105

Merged
merged 8 commits into from
Dec 22, 2024
Merged

FEATURE: Mounts Feeding Needs #105

merged 8 commits into from
Dec 22, 2024

Conversation

OcelotWalrus
Copy link
Member

@OcelotWalrus OcelotWalrus commented Dec 22, 2024

FEATURE/BALANCE

This PR addresses the feature described in issue #104
This PR addresses the game progression goal #Add health to the mounts

Summary

In this PR, mounts have received new stats: health and max health. Mounts now have a health stat, that goes down when training, fighting and regularly when a day passes. The mount's feeding needs stat control how fast the mount's health goes down: the higher that stat is, the faster the health will go down. Here are the calculation processes:

$$TRAINING => mounthealth = mounhealth - feedingneeds * 1.015$$ $$FIGHTING => mounthealth = mounthealth - feedingneeds * numberofenemies * 1.75$$ $$REGULAR DAY => mounthealth = mounthealth - feedingneeds * 2.15$$

Health can be recovered by letting the mount rest in a stabling: each quarter of a day the mount rests in a stabling, it recovers 15% of its max health in current health. It means that a mount, in order to recover from 0 current health to its max, needs to rest in a stabling for about 7 quarter of a day, so about 2 whole days.
Max health is upped by each time a mount level ups by 1 level. Each mount type has a different starting health stat, and a max health addition per level stat.

The player will get warnings when his current mount's health is below 50% (light yellow), 25% (orange), 10% (bright red), 5% (bright red in black outline). When a mount reaches a level of health of 0%, it dies.

Note that I've written the necessary code to allow saves to transition this change (because of the new stats that could cause bugs as they wouldn't be found).

Testing Done

I've tested every way mounts' health can be modified, with success.

Performance Impact

N/A

Check-List

  • Review my own code
  • Fix the workflow checks
  • Warn the player about his mount's state
  • Make the mount dies when at 0% of health
  • Allow between-versions transition for saves
  • Update the schemas
  • Add more logging to the processes

@OcelotWalrus OcelotWalrus added enhancement New feature or request help wanted Extra attention is needed balance An enemy or weapon that seems too powerful or useless, or a mission that seems too easy or hard. mechanics Things dealing with the mechanics & code of how the game works content Adds data to the game vanilla stuff. request This issue is requesting some changes planned This issue's planned to be fixed big This is a big PR/issue text - long This PR/issue proposes text changes that are short labels Dec 22, 2024
@OcelotWalrus OcelotWalrus added this to the New Features milestone Dec 22, 2024
@OcelotWalrus OcelotWalrus self-assigned this Dec 22, 2024
@OcelotWalrus OcelotWalrus linked an issue Dec 22, 2024 that may be closed by this pull request
@OcelotWalrus OcelotWalrus marked this pull request as draft December 22, 2024 13:31
@OcelotWalrus OcelotWalrus marked this pull request as ready for review December 22, 2024 17:00
@OcelotWalrus
Copy link
Member Author

Anything to suggest before I merge?

@lumbar527
Copy link
Member

I don't really have much input.

@OcelotWalrus OcelotWalrus merged commit c5ff4ff into master Dec 22, 2024
12 checks passed
@OcelotWalrus OcelotWalrus deleted the mounts-feeding-needs branch December 22, 2024 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
balance An enemy or weapon that seems too powerful or useless, or a mission that seems too easy or hard. big This is a big PR/issue content Adds data to the game vanilla stuff. enhancement New feature or request help wanted Extra attention is needed mechanics Things dealing with the mechanics & code of how the game works planned This issue's planned to be fixed request This issue is requesting some changes text - long This PR/issue proposes text changes that are short
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FEATURE: Mounts Feeding Needs
2 participants