-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FEATURE: Mounts Feeding Needs #105
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OcelotWalrus
added
enhancement
New feature or request
help wanted
Extra attention is needed
balance
An enemy or weapon that seems too powerful or useless, or a mission that seems too easy or hard.
mechanics
Things dealing with the mechanics & code of how the game works
content
Adds data to the game vanilla stuff.
request
This issue is requesting some changes
planned
This issue's planned to be fixed
big
This is a big PR/issue
text - long
This PR/issue proposes text changes that are short
labels
Dec 22, 2024
Anything to suggest before I merge? |
I don't really have much input. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
balance
An enemy or weapon that seems too powerful or useless, or a mission that seems too easy or hard.
big
This is a big PR/issue
content
Adds data to the game vanilla stuff.
enhancement
New feature or request
help wanted
Extra attention is needed
mechanics
Things dealing with the mechanics & code of how the game works
planned
This issue's planned to be fixed
request
This issue is requesting some changes
text - long
This PR/issue proposes text changes that are short
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FEATURE/BALANCE
This PR addresses the feature described in issue #104
This PR addresses the game progression goal #Add health to the mounts
Summary
In this PR, mounts have received new stats: health and max health. Mounts now have a health stat, that goes down when training, fighting and regularly when a day passes. The mount's
feeding needs
stat control how fast the mount's health goes down: the higher that stat is, the faster the health will go down. Here are the calculation processes:Health can be recovered by letting the mount rest in a stabling: each quarter of a day the mount rests in a stabling, it recovers 15% of its max health in current health. It means that a mount, in order to recover from 0 current health to its max, needs to rest in a stabling for about 7 quarter of a day, so about 2 whole days.
Max health is upped by each time a mount level ups by 1 level. Each mount type has a different starting health stat, and a max health addition per level stat.
The player will get warnings when his current mount's health is below 50% (light yellow), 25% (orange), 10% (bright red), 5% (bright red in black outline). When a mount reaches a level of health of 0%, it dies.
Note that I've written the necessary code to allow saves to transition this change (because of the new stats that could cause bugs as they wouldn't be found).
Testing Done
I've tested every way mounts' health can be modified, with success.
Performance Impact
N/A
Check-List