Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added tvOS target #163

Closed
wants to merge 2 commits into from
Closed

Added tvOS target #163

wants to merge 2 commits into from

Conversation

psegalen
Copy link

Hi, this is an attempt to add tvOS target to this lib, this is related to #162
I'm not able to build the tvOS lib because it doesn't reference React Native (so it doesn't find "React/RCTConvert.h") but given the fact that it doesn't find it either when I try to build the iOS lib, I figured I missed something, could you please point me in the right direction to build it?
Thanks.

@DylanVann
Copy link
Owner

Cool, thanks for working on this.

There's another PR open that changes that RCTConvert import, it might fix it.

@psegalen
Copy link
Author

I tried everything the other PR tried but XCode still won't find the header file... :'(
Maybe it has something to do with my machine, could someone please try and compile the tvOS target on his machine?

@DylanVann
Copy link
Owner

Harder than it looks...

@nic-thomson
Copy link

nic-thomson commented Jul 11, 2018

Had a look at this thru brute force; I was able to get this to compile. The secret is to add
$(inherited)
to the header search paths. Then drag that item to the top of the list.

You must also ensure that both SDWebImage and FastImage TVOS targets have build destinations of Apple TV, when you build, it took a little convincing for SDWebImage to see the simulators.

@gtebbutt
Copy link

gtebbutt commented Mar 12, 2019

Just come across this - was there any major blocker to getting it working based on @nic-thomson's suggestion? Would be very useful to have, but seems to have gone somewhat out of sync now.

@Ilphrin
Copy link

Ilphrin commented May 6, 2019

Hi @psegalen ! Any news on this PR? :3

@iamyellow
Copy link
Contributor

hi! i've made a new PR (#486) since it seems this one have problems merging.

@DylanVann
Copy link
Owner

Closed in favor of @iamyellow 's PR,

@DylanVann DylanVann closed this Jun 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants