Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use application context to avoid deallocated view error #75

Merged
merged 3 commits into from
Nov 30, 2017

Conversation

wz366
Copy link

@wz366 wz366 commented Oct 20, 2017

When split screen on Android, view can be reconstructed; therefore, using view context here can cause crashes on Android. Using application context avoids accessing context of a deallocated view.

@wz366
Copy link
Author

wz366 commented Oct 31, 2017

@wkoutre It actually works without force command :)

@wkoutre
Copy link

wkoutre commented Nov 3, 2017

@wz366 Not for me it doesn't ;)

@wz366
Copy link
Author

wz366 commented Nov 3, 2017

@wkoutre what is your OS?

@wkoutre
Copy link

wkoutre commented Nov 6, 2017

@wz366 macOS 10.13

@DylanVann DylanVann merged commit 1d16c7c into DylanVann:master Nov 30, 2017
@DylanVann
Copy link
Owner

Awesome! Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants