Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DYN-7391 [Cherry-pick]ASM 231 update follow-up (#15624) #15627

Merged
merged 1 commit into from
Nov 11, 2024
Merged

DYN-7391 [Cherry-pick]ASM 231 update follow-up (#15624) #15627

merged 1 commit into from
Nov 11, 2024

Conversation

QilongTang
Copy link
Contributor

Purpose

Cherry-pick #15624 into RC3.4.0_master branch

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated
  • This PR contains no files larger than 50 MB

Release Notes

N/A

Reviewers

FYIs

@DynamoDS/dynamo

@QilongTang QilongTang added this to the 3.4 milestone Nov 11, 2024
github-actions[bot]
github-actions bot reviewed Nov 11, 2024
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-7391

@QilongTang QilongTang changed the title DYN-7391 ASM 231 update follow-up (#15624) DYN-7391 [Cherry-pick]ASM 231 update follow-up (#15624) Nov 11, 2024
@github-actions GitHub Actions
Copy link

UI Smoke Tests

Test: success. 11 passed, 0 failed.
TestComplete Test Result
Workflow Run: UI Smoke Tests
Check: UI Smoke Tests

@QilongTang
Copy link
Contributor Author

PR check passed at: https://master-5.jenkins.autodesk.com/job/Dynamo/job/DynamoSelfServe/job/pullRequestValidation/16772/

@QilongTang QilongTang merged commit 7dcc1d1 into RC3.4.0_master Nov 11, 2024
28 of 29 checks passed
@QilongTang QilongTang deleted the Cherry-pick branch November 11, 2024 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@reddyashish reddyashish reddyashish approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.4
Development

Successfully merging this pull request may close these issues.
2 participants
@QilongTang @reddyashish