-
Notifications
You must be signed in to change notification settings - Fork 632
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DYN-7778 Package details compatible version tooltip #15640
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-7778
UI Smoke TestsTest: success. 11 passed, 0 failed. |
@@ -4089,4 +4089,7 @@ To make this file into a new template, save it to a different folder, then move | |||
<data name="PackageIncompatibleFilterTooltip" xml:space="preserve"> | |||
<value>Versions maybe incompatible with the current setup</value> | |||
</data> | |||
<data name="PackageVersionTooltip" xml:space="preserve"> | |||
<value>Versions marked with .x include all versions in the specified major release</value> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In future when we start supporting asterisk with minor version 3.2.*, the tooltip will become incorrect as it will always indicate major release. @hwahlstrom @avidit . Thoughts?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@zeusongit Update the tooltip when we start supporting minor version?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, we can update that later in the next version but, we won't be able to update it in 3.4, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@zeusongit Will supporting minor version be needed for 3.4 then? Should I go ahead with the cherrypick to 3.4?
FYI @QilongTang
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, we will not be supporting minor version for 3.4, what I mean is that when we start supporting minor version that data will start to show up in 3.4 package manager as well, and the tooltip will still say major version.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got it, we should decide on that then before merging to 3.4 branch. @hwahlstrom
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Then we can just have it say "...specified major or minor release."
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changed in here #15648
(cherry picked from commit 0e16d1f)
Purpose
https://jira.autodesk.com/browse/DYN-7778
Adding a tooltip info for the compatible versions shown in package details viewextension
Declarations
Check these if you believe they are true
*.resx
filesRelease Notes
DYN-7778 Package details compatible version tooltip
Reviewers
@zeusongit @dnenov @hwahlstrom