Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DYN-7778 Package details compatible version tooltip #15640

Merged
merged 2 commits into from
Nov 13, 2024

Conversation

reddyashish
Copy link
Contributor

@reddyashish reddyashish commented Nov 12, 2024

Purpose

https://jira.autodesk.com/browse/DYN-7778

Adding a tooltip info for the compatible versions shown in package details viewextension

Screenshot 2024-11-12 at 1 23 59 PM

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated
  • This PR contains no files larger than 50 MB

Release Notes

DYN-7778 Package details compatible version tooltip

Reviewers

@zeusongit @dnenov @hwahlstrom

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-7778

Copy link

UI Smoke Tests

Test: success. 11 passed, 0 failed.
TestComplete Test Result
Workflow Run: UI Smoke Tests
Check: UI Smoke Tests

@@ -4089,4 +4089,7 @@ To make this file into a new template, save it to a different folder, then move
<data name="PackageIncompatibleFilterTooltip" xml:space="preserve">
<value>Versions maybe incompatible with the current setup</value>
</data>
<data name="PackageVersionTooltip" xml:space="preserve">
<value>Versions marked with .x include all versions in the specified major release</value>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In future when we start supporting asterisk with minor version 3.2.*, the tooltip will become incorrect as it will always indicate major release. @hwahlstrom @avidit . Thoughts?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zeusongit Update the tooltip when we start supporting minor version?

Copy link
Contributor

@zeusongit zeusongit Nov 13, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, we can update that later in the next version but, we won't be able to update it in 3.4, right?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zeusongit Will supporting minor version be needed for 3.4 then? Should I go ahead with the cherrypick to 3.4?
FYI @QilongTang

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, we will not be supporting minor version for 3.4, what I mean is that when we start supporting minor version that data will start to show up in 3.4 package manager as well, and the tooltip will still say major version.

Copy link
Contributor Author

@reddyashish reddyashish Nov 13, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it, we should decide on that then before merging to 3.4 branch. @hwahlstrom

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Then we can just have it say "...specified major or minor release."

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed in here #15648

@QilongTang QilongTang added this to the 3.4 milestone Nov 13, 2024
@reddyashish reddyashish merged commit 0e16d1f into DynamoDS:master Nov 13, 2024
26 checks passed
reddyashish added a commit to reddyashish/Dynamo that referenced this pull request Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants