Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DYN-7826: pm compatibility bug fix #15651

Merged
merged 1 commit into from
Nov 14, 2024

Conversation

dnenov
Copy link
Collaborator

@dnenov dnenov commented Nov 14, 2024

Purpose

Bugfix - returning True when no compatibility single version was found. For reference jira issue

image

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated
  • This PR contains no files larger than 50 MB

Release Notes

  • flipped isWithinMinMax initial bool value to False
  • added Tests to cover this case

Reviewers

@achintyabhat
@zeusongit
@saintentropy
@QilongTang

FYIs

@reddyashish

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-7826

@QilongTang QilongTang added this to the 3.4 milestone Nov 14, 2024
Copy link

UI Smoke Tests

Test: success. 11 passed, 0 failed.
TestComplete Test Result
Workflow Run: UI Smoke Tests
Check: UI Smoke Tests

@QilongTang QilongTang merged commit d40d4da into DynamoDS:master Nov 14, 2024
31 checks passed
@QilongTang
Copy link
Contributor

@dnenov Can you cherry-pick this to RC3.4 branch?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants