DYN-7471 Add compatibility matrix deserialization #113
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Adding compatibility matrix to PMClient with deserialization so Dynamo gets a collection of different compatibility info instead of a string.
The PR introduces changes to the compatibility schema:
The changes are not huge, it is proposed to change the json structure from a dictionary to an array of objects, reason behind this is since we need to deserialize this json property into a dictionary, we will also need to convert it into an observable collection when consuming it in Dynamo, an Observable Dictionary is more complex and will probably require creating this Observable Dictionary class from scratch, I feel using an already existing Observable Collection makes more sense.
The schema wiki has been updated with the new proposal, also added a test for deserialization.
Declarations
Check these if you believe they are true
Reviewers
(FILL ME IN) Reviewer 1 (If possible, assign the Reviewer for the PR)
(FILL ME IN, optional) Any additional notes to reviewers or testers.
FYIs
(FILL ME IN, Optional) Names of anyone else you wish to be notified of