Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add missing dependency to sh for RPM linux packages #264

Merged
merged 3 commits into from
Aug 8, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions .chloggen/add-missing-dep.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
# Use this changelog template to create an entry for release notes.

# One of 'breaking', 'deprecation', 'new_component', 'enhancement', 'bug_fix'
change_type: bug_fix

# The name of the component, or a single word describing the area of concern, (e.g. filelogreceiver)
component: release

# A brief description of the change. Surround your text with quotes ("") if it needs to start with a backtick (`).
note: Add missing dependency to /bin/sh to the RPM linux package

# Mandatory: One or more tracking issues related to the change. You can use the PR number here if no issue exists.
issues: [264]

# (Optional) One or more lines of additional information to render under the primary note.
# These lines will be padded with 2 spaces and then inserted directly into the document.
# Use pipe (|) for multiline entries.
subtext:
4 changes: 4 additions & 0 deletions .goreleaser.yaml
mowies marked this conversation as resolved.
Show resolved Hide resolved
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,10 @@ nfpms:
- apk
- deb
- rpm
overrides:
rpm:
dependencies:
- /bin/sh
mowies marked this conversation as resolved.
Show resolved Hide resolved
maintainer: "Dynatrace LLC <opensource@dynatrace.com>"
vendor: "Dynatrace LLC"
description: Dynatrace distribution of the OpenTelemetry Collector
Expand Down
10 changes: 9 additions & 1 deletion docs/releasing.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,15 @@ This document describes the steps to release a new version of the Dynatrace dist

Before starting a release, make a PR against to verify and update the following:

1. Ensure `manifest.yaml` contains all desired Collector components at the
1. Make sure that there were no updates to the linux packages
- check the goreleaser files upstream for changes under the `nfpms` key
- check the upstream installation lifecycle scripts as well as the service config files for changes:
- `postinstall.sh`
- `preinstall.sh`
- `preremove.sh`
- `otelcol.conf`
- `otelcol.service`
2. Ensure `manifest.yaml` contains all desired Collector components at the
desired version. It is recommended that the component versions depend on the
same minor version of the Collector. For components in the upstream Collector
repos, most of the time this means they will be the same version as the
Expand Down
Loading