Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

l_ieflx_fix defined but unused #2731

Closed
kaizhangpnl opened this issue Feb 6, 2019 · 0 comments · Fixed by #2730
Closed

l_ieflx_fix defined but unused #2731

kaizhangpnl opened this issue Feb 6, 2019 · 0 comments · Fixed by #2730
Assignees
@kaizhangpnl
Labels
Atmosphere bug

Comments

@kaizhangpnl
Copy link
Contributor

kaizhangpnl commented Feb 6, 2019 •
edited
Loading

One F90 file was missing when #1498 was merged to master. l_ieflx_fix is defined but unused in components/cam/src/physics/cam/phys_control.F90. This caused some confusion and the namelist definition for l_ieflx_fix was brought back in #1790. This problem was found during the pull request process for #2721.

#2730 has been issued to resolve this problem.
@kaizhangpnl kaizhangpnl self-assigned this Feb 6, 2019
This was referenced Feb 6, 2019
Merged
Merged
singhbalwinder added a commit that referenced this issue Apr 19, 2019
@singhbalwinder
Merge branch 'kaizhangpnl/atm/ieflx_cleanup2' into next (PR #2730)
8924f9b 
remove l_ieflx_fix

removed l_ieflx_fix in

- components/cam/bld/namelist_files/namelist_definition.xml
- components/cam/src/physics/cam/phys_control.F90
- use_cases namelist files (under components/cam/bld/...
...namelist_files/use_cases)

[BFB]

Fixes #2731

* kaizhangpnl/atm/ieflx_cleanup2:
  delete l_ieflx_fix in use_cases namelist files
  remove l_ieflx_fix
singhbalwinder added a commit that referenced this issue Apr 23, 2019
@singhbalwinder
Merge branch 'kaizhangpnl/atm/ieflx_cleanup2' (PR #2730)
8eb6019 
remove l_ieflx_fix

removed l_ieflx_fix in

- components/cam/bld/namelist_files/namelist_definition.xml
- components/cam/src/physics/cam/phys_control.F90
- use_cases namelist files (under components/cam/bld/...
...namelist_files/use_cases)

[BFB]

Fixes #2731

* kaizhangpnl/atm/ieflx_cleanup2:
  delete l_ieflx_fix in use_cases namelist files
  remove l_ieflx_fix
jgfouca pushed a commit that referenced this issue Jun 25, 2019
@jedwards4b
Merge pull request #3019 from jedwards4b/batch_and_resubmit
1c0bf27 
Batch and resubmit
Move the logic to check and update batch options so that it is invoked on resubmit as well as on an initial submit

Test suite: scripts_regression_tests.py some hand testing
Test baseline:
Test namelist changes:
Test status: bit for bit
Fixes #2731

User interface changes?:

Update gh-pages html (Y/N)?:

Code review:
bartgol pushed a commit that referenced this issue Mar 27, 2024
@E3SM-Autotester
Merge Pull Request #2731 from E3SM-Project/scream/bartgol/eamxx/fix-b…
a25b55e 
…ug-related-to-layouts-extents

Automatically Merged using E3SM Pull Request AutoTester
PR Title: Fix issue in FieldLayout related to shallow copies
PR Author: bartgol
PR LABELS: AT: AUTOMERGE, bugfix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kaizhangpnl kaizhangpnl

Labels
Atmosphere bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

remove l_ieflx_fix E3SM-Project/E3SM
1 participant
@kaizhangpnl