Add lost code to set variable based on ic_mode, for ICG compsets. #1297
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonbob
added a commit
that referenced
this pull request
Mar 2, 2017
Add lost code to set variable based on ic_mode, for ICG compsets This PR will add back some coding to set the mpas-cice config_initial_condition_type based on the IC_MODE in build-namelist. This is required for ICG compsets and was somehow lost. [BFB]
jonbob
added a commit
that referenced
this pull request
Mar 2, 2017
Add lost code to set variable based on ic_mode, for ICG compsets This PR will add back some coding to set the mpas-cice config_initial_condition_type based on the IC_MODE in build-namelist. This is required for ICG compsets and was somehow lost. [BFB]
jgfouca
pushed a commit
that referenced
this pull request
Sep 15, 2017
Get PFUnit working on melvin. Fix up serial settings in melvin. Need to explicitly declare PFUNIT_PATH in cmake calls in run_tests.py Need to load env before making env XML files, some compiler vars pull from environment Need to not crash when CMAKE_Fortran_COMPILER_ID is empty Test suite: scripts_regression_tests.py N_TestUnitTest Test baseline: Test namelist changes: Test status: bit for bit Fixes #1297 User interface changes?: N Update gh-pages html (Y/N)?: N Code review: @billsacks @jedwards4b (confirmed N_TestUnitTest still works on cheyenne)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will add back some coding to set the mpas-cice config_initial_condition_type based on the IC_MODE in build-namelist. This is required for ICG compsets and was somehow lost.
[BFB]