Separate removal of Antarctic river and ice runoff #6510
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The totals are computed incorrectly (they are missing areaCell) and are not currently used for anything within MPAS-Ocean or any diagnostics.
This is needed so so we can remove ice (solid) runoff but not river (liquid) runoff.
|
@jonbob, could you double check that I haven't messed up the namelist propagation from Registry to E3SM? |
darincomeau
approved these changes
Jul 12, 2024
cbegeman
approved these changes
Jul 12, 2024
There was a problem hiding this comment.
Approved based on review in E3SM-Ocean-Discussion#105. Let me know if you'd like any help with further testing.
|
@xylar -- the bld files all look perfect. Thanks! |
|
I ran e3sm_cryo_developer on chrysalis and got NML DIFFs for all of the tests, but these were otherwise BFB: only was non-BFB. But maybe that makes sense -- CORE-II forcing doesn't have any frozen runoff |
|
A test of also passes but has a NML DIFF, as expected |
jonbob
added a commit
that referenced
this pull request
Jul 16, 2024
…ext (PR #6510) Separate removal of Antarctic river and ice runoff This is needed so we can remove ice (solid) runoff but not river (liquid) runoff. This merge also removes totalRemoved*RunoffFlux variables. These fields are computed incorrectly (they are missing areaCell) and are not currently used for anything within MPAS-Ocean or any diagnostics. [NML] for all configurations with mpas-ocean [non-BFB] only for simulations with JRA forcing, DIB and either DISMF or PISMF (data icebergs and data or prognostic melt rates)
|
merged to next |
|
merged to master and expected NML and regular DIFFs blessed |
xylar
added a commit
to xylar/compass
that referenced
this pull request
Aug 8, 2024
This merge updates the E3SM-Project submodule from [c7d7998](https://github.com/E3SM-Project/E3SM/tree/c7d7998) to [727ad81](https://github.com/E3SM-Project/E3SM/tree/727ad81). This update includes the following MPAS-Ocean and MPAS-Frameworks PRs (check mark indicates bit-for-bit with previous PR in the list): - [ ] (ocn) E3SM-Project/E3SM#6456 - [ ] (ocn) E3SM-Project/E3SM#6510 - [ ] (ocn) E3SM-Project/E3SM#6535
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is needed so we can remove ice (solid) runoff but not river (liquid) runoff.
This merge also removes
totalRemoved*RunoffFluxvariables. These fields are computed incorrectly (they are missingareaCell) and are not currently used for anything within MPAS-Ocean or any diagnostics.This is part of the design: https://acme-climate.atlassian.net/wiki/spaces/PSC/pages/4210098268/Design+Document+Data+iceberg+and+ice-shelf+melt+flux+patterns+for+E3SM+spin-up+runs
This is a high priority for the Polar team.
See E3SM-Ocean-Discussion#105 for some useful discussion and testing
[NML]
[non-BFB] for simulations with DIB and either DISMF or PISMF (data icebergs and data or prognostic melt rates)
[BFB] for simulations with snow-capping (e.g. current E3SM v3 production runs)