-
Notifications
You must be signed in to change notification settings - Fork 363
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
slightly improve v3 run_script template #6534
Conversation
|
local this_script_name=`basename $0` | ||
local this_script_name=$( basename -- "$0"; ) | ||
local this_script_dir=$( dirname -- "$0"; ) | ||
local script_provenance_name=${this_script_name}.`date +%Y%m%d-%H%M%S` | ||
cp -vp ${this_script_name} ${script_provenance_dir}/${script_provenance_name} | ||
cp -vp "${this_script_dir}/${this_script_name}" ${script_provenance_dir}/${script_provenance_name} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note that these edits were made because this specific function before won't work if the script is submitted non-interactively. With the fix, it works fine. I don't know what the problem is exactly....
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't understand why, but I'll trust you on that.
echo $'\n CUSTOMIZE PROCESSOR CONFIGURATION:' | ||
|
||
# Number of cores per node (machine specific) | ||
if [ "${MACHINE}" == "pm-cpu" ]; then |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mahf708 : could you add more E3SM machines (compy, chrysalis, anvil) here to make it more portable?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good! Will address soon.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added compy, chrys and anvil. Note that @rljacob indicated in the past that this script was aimed primarily at pm-cpu users, hence I didn't add them originally. I can further customize the CASE_ROOT to suit all machines ($PSCRATCH on pm-cpu, /lcrc/group/e3sm/$USER on chrys and anvil, and /compyfs/$USER on compy if desired). I am in favor of portability (but I didn't want to make the logic complex preemptively) so let me know if you'd like that extended as well
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes because pm-cpu is our only officially supported machine.
local this_script_name=`basename $0` | ||
local this_script_name=$( basename -- "$0"; ) | ||
local this_script_dir=$( dirname -- "$0"; ) | ||
local script_provenance_name=${this_script_name}.`date +%Y%m%d-%H%M%S` | ||
cp -vp ${this_script_name} ${script_provenance_dir}/${script_provenance_name} | ||
cp -vp "${this_script_dir}/${this_script_name}" ${script_provenance_dir}/${script_provenance_name} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't understand why, but I'll trust you on that.
@golaz please approve. |
Automates $PSCRATCH location for code and case, adds custom_pelayout for supported machines, hardens copy_script, and sets default PROJECT for slurm-based machines. [BFB]
Automates $PSCRATCH location for code and case, adds custom_pelayout for supported machines, hardens copy_script, and sets default PROJECT for slurm-based machines.
[BFB]