-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1.3.1 #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed the system MPI version of the envrionment, which was largely unsuccessful.
Attepts to use system MPI were only successful for mpi4py and not other packages.
More efficient change of permissions.
This is needed so all python versions get built. Without it, the python build matrix seems to be ignored.
xylar
force-pushed
the
1.3.1
branch
2 times, most recently
from
July 15, 2020 21:39
cb1e0f5
to
56b8ae5
Compare
This is hopefully a temporary hack for just this release.
This allows us to define environments with python dictionaries, increasing control and flexibility. The permissions are also more efficient to change with this approach.
jhkennedy
approved these changes
Jul 16, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, I just have some minor comments.
Move env definitions to the top of the script. Pull out running shell commands into a single function. Move host-related info higher in the script for easier editing.
jhkennedy
approved these changes
Jul 16, 2020
E3SM_Diags needs an earlier version of dask, <=2.15.0, to run correctly with multiprocessing The script cdscan was not python-3 compatible in cdms2 until a patch was added in build 11.
CI will fail until build 11 of cdms2 gets merged: conda-forge/cdms2-feedstock#57 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update to v1.3.1
Main packages and versions are:
NCL has been removed because it does not support the latest hdf5 (1.10.6) needed by several other packages. It will be added again in the next version if possible.
The CDAT metapackage has been removed because it includes the basemap package that conflicts with other packages. If a new CDAT metapacakge is released without basemap, it will be included in the next version of E3SM-Unified.