Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

4.1-coreを4.1へ反映 #5088

Merged
merged 15 commits into from
Jul 12, 2021
Merged

4.1-coreを4.1へ反映 #5088

merged 15 commits into from
Jul 12, 2021

Conversation

chihiro-adachi
Copy link
Contributor

概要(Overview・Refs Issue)

#5079 #5081 を4.1ブランチへ反映しました。

方針(Policy)

実装に関する補足(Appendix)

テスト(Test)

相談(Discussion)

マイナーバージョン互換性保持のための制限事項チェックリスト

  • 既存機能の仕様変更
  • フックポイントの呼び出しタイミングの変更
  • フックポイントのパラメータの削除・データ型の変更
  • twigファイルに渡しているパラメータの削除・データ型の変更
  • Serviceクラスの公開関数の、引数の削除・データ型の変更
  • 入出力ファイル(CSVなど)のフォーマット変更

レビュワー確認項目

  • 動作確認
  • コードレビュー
  • E2E/Unit テスト確認(テストの追加・変更が必要かどうか)
  • 互換性が保持されているか
  • セキュリティ上の問題がないか

@chihiro-adachi chihiro-adachi added the enhancement 機能追加 label Jul 9, 2021
@chihiro-adachi chihiro-adachi added this to the 4.1 milestone Jul 9, 2021
@codecov-commenter
Copy link

Codecov Report

Merging #5088 (1191507) into 4.1 (6149c4c) will decrease coverage by 0.02%.
The diff coverage is 88.23%.

Impacted file tree graph

@@             Coverage Diff              @@
##                4.1    #5088      +/-   ##
============================================
- Coverage     75.71%   75.68%   -0.03%     
- Complexity     6016     6025       +9     
============================================
  Files           454      456       +2     
  Lines         21125    21142      +17     
============================================
+ Hits          15994    16002       +8     
- Misses         5131     5140       +9     
Flag Coverage Δ
tests 75.68% <88.23%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...e/Form/Extension/HTMLPurifierTextTypeExtension.php 84.61% <84.61%> (ø)
...Eccube/Form/EventListener/HTMLPurifierListener.php 100.00% <100.00%> (ø)
src/Eccube/Form/Type/Admin/MemberType.php 75.51% <0.00%> (-20.41%) ⬇️
...be/Service/PurchaseFlow/Processor/TaxProcessor.php 83.33% <0.00%> (+3.70%) ⬆️
src/Eccube/Request/Context.php 100.00% <0.00%> (+3.84%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6149c4c...1191507. Read the comment docs.

@okazy okazy merged commit 0a7b04f into EC-CUBE:4.1 Jul 12, 2021
@okazy
Copy link
Contributor

okazy commented Jul 12, 2021

ありがとうございます。マージしました。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement 機能追加
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants