-
Notifications
You must be signed in to change notification settings - Fork 648
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP]支払い方法を変更した時に支払い方法のアンカーへ移動 #5187
Open
tao-s
wants to merge
1
commit into
EC-CUBE:4.1
Choose a base branch
from
tao-s:patch-22
base: 4.1
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
大丈夫かと思いますが、 URL fragment を動的に追加している箇所は念には念を入れてペネトレーションテストも追加しておきたいです |
chihiro-adachi
changed the title
支払い方法を変更した時に支払い方法のアンカーへ移動
[WIP]支払い方法を変更した時に支払い方法のアンカーへ移動
May 20, 2022
@tao-s こちらの件ご対応いただけそうでしょうか?ぜひ次のバージョンで入れさせていただきたいです! |
@xuelian311 遅くなりすいません。これって何を対応すれば良いんですか? |
@nanasess これってテスト書けってことなんですかね? |
@tao-s url-fragment 攻撃の問題ないことを、OWASP Zap のテスト書いて確認したかったのですが、テストの構成が変わって難しくなってしまいましたね。。。 手動でテストするしかないか🤔 |
@ji-eunsoo 手動でテストするしかないと思います |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
概要(Overview・Refs Issue)
支払い方法を変更した場合にページトップではなく支払い方法のアンカーへ
#5186
テスト(Test)
稼働しているコードですが、
ShoppingController::redirectTo()
を変えてるので他の環境だとエラーが出る可能性があるので確認してください。相談(Discussion)
できればControllerのannotationでflagmentの設定したいけどよくわからん。
tao-s@0f69bcd#diff-21c4d1297a9e1961c312211f32d8c1184a995d79a993bc53535638dfceda5049R208
この辺りもっと良いやり方がありそう。あとこの書き方だとバグが出そう
マイナーバージョン互換性保持のための制限事項チェックリスト
レビュワー確認項目