Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHPStan のエラーを修正 #493

Merged
merged 3 commits into from
Nov 16, 2021
Merged

Conversation

nanasess
Copy link
Contributor

------ ------------------------------------------------------------- 
 Line   class/pages/upgrade/LC_Page_Upgrade_Download.php             
------ ------------------------------------------------------------- 
 162    Variable $objRet in empty() always exists and is not falsy.  
------ ------------------------------------------------------------- 

------ ------------------------------------------------------------- 
 Line   class/pages/upgrade/LC_Page_Upgrade_ProductsList.php         
------ ------------------------------------------------------------- 
 116    Variable $objRet in empty() always exists and is not falsy.  
 176    Variable $objRet in empty() always exists and is not falsy.  
------ ------------------------------------------------------------- 

@return アノテーションの間違い

 ------ --------------------------------------------------------------- 
  Line   class/util/SC_Utils.php                                        
 ------ --------------------------------------------------------------- 
  1899   Variable $filename in empty() always exists and is not falsy.  
 ------ --------------------------------------------------------------- 

$filenamestring|false なので empty() で評価できない

 ------ --------------------------------------------------------------- 
  Line   smarty_extends/function.html_checkboxes_ex.php                 
 ------ --------------------------------------------------------------- 
  105    Variable $values in isset() always exists and is always null.  
 ------ --------------------------------------------------------------- 

 ------ --------------------------------------------------------------- 
  Line   smarty_extends/function.html_radios_ex.php                     
 ------ --------------------------------------------------------------- 
  107    Variable $values in isset() always exists and is always null.  
 ------ --------------------------------------------------------------- 

エラーメッセージが変更されたため、ignoreErrors から漏れてしまった

@codecov-commenter
Copy link

Codecov Report

Merging #493 (1ed7795) into master (eb43f49) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #493   +/-   ##
=========================================
  Coverage     46.62%   46.62%           
  Complexity       14       14           
=========================================
  Files            81       81           
  Lines         10580    10580           
=========================================
  Hits           4933     4933           
  Misses         5647     5647           
Flag Coverage Δ
tests 46.62% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
data/class/util/SC_Utils.php 52.87% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eb43f49...1ed7795. Read the comment docs.

@nanasess nanasess force-pushed the fix-phpstan branch 2 times, most recently from 92020b9 to 1f30ddf Compare November 10, 2021 13:24
@nanasess
Copy link
Contributor Author

Windows のホストランナーで mailcatcher がビルドできなくなり、 Docker も使用できなかったため削除しました

@nanasess nanasess added this to the 2.17.3 milestone Nov 12, 2021
@matsuoshi matsuoshi merged commit 383b5f1 into EC-CUBE:master Nov 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants