Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

macOS で Playwright がエラーになるのを修正 #518

Merged
merged 7 commits into from
Feb 16, 2022

Conversation

nanasess
Copy link
Contributor

@nanasess nanasess commented Jan 27, 2022

  • macOS では、 環境変数から proxy の情報を渡せない模様
  • playwright.config.ts で proxy の設定をするよう修正
    • 環境変数 HTTP_PROXY が設定されている場合は、その情報を引き継ぐ
  • GitHub Actions では環境変数から proxy の情報を渡さないと RequestError: Error: getaddrinfo EAI_AGAIN undefined になってしまう
    • Linux のローカル環境(WSL2など)でも同様に環境変数 HTTP_PROXY 及び HTTPS_PROXY を渡す必要がある
  • see OWASP ZAP 自動化手順の README 追加 ec-cube#5183 (comment)

@chihiro-adachi
Copy link
Contributor

@nanasess
テストが1件落ちていますが問題ないでしょうか?

@chihiro-adachi chihiro-adachi added this to the 2.17.3 milestone Feb 9, 2022
@nanasess
Copy link
Contributor Author

nanasess commented Feb 9, 2022

@nanasess

テストが1件落ちていますが問題ないでしょうか?

全く関係ない箇所ですので問題ないと思います

@codecov-commenter
Copy link

codecov-commenter commented Feb 15, 2022

Codecov Report

Merging #518 (5349c38) into master (bf7d535) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #518   +/-   ##
=======================================
  Coverage   54.40%   54.40%           
=======================================
  Files          76       76           
  Lines        9039     9039           
=======================================
  Hits         4918     4918           
  Misses       4121     4121           
Flag Coverage Δ
tests 54.40% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bf7d535...5349c38. Read the comment docs.

@chihiro-adachi
Copy link
Contributor

@nanasess
ありがとうございます、マージしました。

@nanasess nanasess deleted the fix-http_proxy branch October 3, 2022 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants