Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply yarn upgrade --latest #527

Merged
merged 2 commits into from
Mar 16, 2022
Merged

Conversation

nanasess
Copy link
Contributor

@nanasess nanasess commented Mar 3, 2022

  • faker が終了したため @faker-js/faker に変更
  • yarn upgrade --latest を実行

- faker が終了したため @faker-js/faker に変更
@codecov-commenter
Copy link

codecov-commenter commented Mar 3, 2022

Codecov Report

Merging #527 (ddadb44) into master (4b76107) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #527   +/-   ##
=======================================
  Coverage   54.40%   54.40%           
=======================================
  Files          76       76           
  Lines        9039     9039           
=======================================
  Hits         4918     4918           
  Misses       4121     4121           
Flag Coverage Δ
tests 54.40% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4b76107...ddadb44. Read the comment docs.

@nanasess
Copy link
Contributor Author

nanasess commented Mar 3, 2022

php.net が落ちているようなので、 PHPUnit がエラーになっていますが、本PRには影響無い模様です。
PHPStan のエラーは #522 で修正済み

@nanasess
Copy link
Contributor Author

nanasess commented Mar 7, 2022

php.net が落ちているようなので、 PHPUnit がエラーになっていますが、本PRには影響無い模様です。

wget でソースを取得しようとすると HTTP Status 503 が返ってくる。 curl なら問題なし。みんな困っている模様
https://bugs.php.net/bug.php?id=81056

@kiy0taka kiy0taka merged commit 9e449ac into EC-CUBE:master Mar 16, 2022
@nanasess nanasess deleted the apply-yarn-upgrade branch October 3, 2022 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants