Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

カートページのテストを fixture を使用したものに変更 #534

Merged
merged 2 commits into from
Mar 30, 2022

Conversation

nanasess
Copy link
Contributor

@nanasess nanasess commented Mar 22, 2022

手続き型の処理だと、スキャン後にカートが空になってしまい、カート加算/減算のテストができないため
@nanasess nanasess marked this pull request as ready for review March 23, 2022 06:20
@nanasess nanasess changed the title [WIP] カートページのテストを fixture を使用したものに変更 カートページのテストを fixture を使用したものに変更 Mar 23, 2022
@nanasess
Copy link
Contributor Author

一通り動作するようになったので WIP はずしました

@codecov-commenter
Copy link

Codecov Report

Merging #534 (0d55e8f) into master (0c0c25a) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #534   +/-   ##
=======================================
  Coverage   54.53%   54.53%           
=======================================
  Files          76       76           
  Lines        9065     9065           
=======================================
  Hits         4944     4944           
  Misses       4121     4121           
Flag Coverage Δ
tests 54.53% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0c0c25a...0d55e8f. Read the comment docs.

@chihiro-adachi chihiro-adachi added this to the 2.17.3 milestone Mar 30, 2022
@chihiro-adachi
Copy link
Contributor

@nanasess
ありがとうございます。マージしました。

@chihiro-adachi chihiro-adachi merged commit 5b5ed96 into EC-CUBE:master Mar 30, 2022
@nanasess nanasess deleted the fix-cart-testing branch October 3, 2022 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants