Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

無効な配送方法が選択された場合, E_USER_ERROR をスローする #602

Merged
merged 1 commit into from
Oct 12, 2022

Conversation

nanasess
Copy link
Contributor

@nanasess nanasess commented Oct 5, 2022

お支払い方法と同様に、配送方法もチェックする

@seasoftjapan
Copy link
Contributor

1商品種別に2つの配送業者を割り当てたら、どちらを選んでも Fatal error(E_USER_ERROR): 無効な配送方法 になりました。
@nanasess 👇だったりしませんか?

diff --git data/class/pages/shopping/LC_Page_Shopping_Payment.php data/class/pages/shopping/LC_Page_Shopping_Payment.php
index d0ee7e83a..c87a6a002 100644
--- data/class/pages/shopping/LC_Page_Shopping_Payment.php
+++ data/class/pages/shopping/LC_Page_Shopping_Payment.php
@@ -380,9 +380,9 @@ public function lfRegistData($uniqid, $arrForm, &$objPurchase, $arrPayment)
 
         $objDelivery = new SC_Helper_Delivery();
         $validDelivery = array_filter($objDelivery->getList($this->cartKey), function ($delivery) use ($arrForm) {
-            return $arrForm['deliv_id'] != $delivery['deliv_id'];
+            return $arrForm['deliv_id'] == $delivery['deliv_id'];
         });
-        if (!empty($validDelivery)) {
+        if (empty($validDelivery)) {
             trigger_error('無効な配送方法: ' . var_export($arrForm['deliv_id'], true), E_USER_ERROR);
         }

@seasoftjapan
Copy link
Contributor

@nanasess
…と思ったら、以下で修正されている感じですね。
95df9d7

これが、master に取り込まれていないのですかね。

@nanasess
Copy link
Contributor Author

@seasoftjapan はい、まだ取り込まれてないんです😢

@seasoftjapan
Copy link
Contributor

週次ビルド出してて、修正も PR されてて、このレベルのが反映されないのも酷い話だと思うのですが、一定の基準で自動マージとかって、できないですかね。

@nanasess
Copy link
Contributor Author

@seasoftjapan ちょっと開発チームにプッシュしてみますね

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants