Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setasign/fpdf の更新に伴う修正 #652

Merged
merged 2 commits into from
Dec 26, 2022

Conversation

nanasess
Copy link
Contributor

@nanasess nanasess commented Dec 6, 2022

#638 において、 PDF 生成時にシステムエラーが発生していた。

fpdf-1.8.5 は fpdi-2.x を使用する必要があるが、システム要件が PHP5.6+となってしまう。
fpdf-1.8.4 の _out() メソッドを SC_Helper_FPDI クラスに移植することで、fpdi-1.6.2 にも対応する

fpdf-1.8.5 は fpdi-2.x を使用する必要があるが、システム要件が PHP5.6+
となってしまう。
fpdf-1.8.4 の _out() メソッドを SC_Helper_FPDI クラスに移植することで、
fpdi-1.6.2 でも動作する
@codecov-commenter
Copy link

Codecov Report

Merging #652 (dc13f70) into master (d89fe7f) will increase coverage by 0.00%.
The diff coverage is 60.00%.

@@           Coverage Diff           @@
##           master     #652   +/-   ##
=======================================
  Coverage   55.33%   55.33%           
=======================================
  Files          75       75           
  Lines        8892     8902   +10     
=======================================
+ Hits         4920     4926    +6     
- Misses       3972     3976    +4     
Flag Coverage Δ
tests 55.33% <60.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
data/class/helper/SC_Helper_FPDI.php 24.00% <60.00%> (+5.53%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@nanasess nanasess changed the title Bump setasign/fpdf from 1.8.4 to 1.8.5 setasign/fpdf の更新に伴う修正 Dec 20, 2022
@chihiro-adachi chihiro-adachi merged commit 4f65a97 into EC-CUBE:master Dec 26, 2022
@chihiro-adachi chihiro-adachi added this to the 2.17.3 milestone Dec 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants