WEBインストーラーのテンプレート改善 (#783, #810 を含む) #813
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- 画像を使わず CSS で対応。 - ロード完了前も表示対応とした。 - 画像とともに使われていない (既に404 だった) jquery.colorbox の CSS/JS も削除した。 - beforeunload イベントで表示するようにした。
sass-convert --indent=4 --to=scss html/install/css/admin_contents.css html/install/css/admin_contents.css
- 不自然な記述となった箇所を補正した。 - 利用のないセレクターを削除した。 - 重複した記述を削除した。 - あまりにも古いブラウザーバージョン互換を削除した。
- HTML をシンプルに。 - 画像を使わない。
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #813 +/- ##
=======================================
Coverage 55.33% 55.33%
=======================================
Files 75 75
Lines 8902 8902
=======================================
Hits 4926 4926
Misses 3976 3976
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
seasoftjapan
changed the title
- JavaScript の追加位置が不適切(IF分岐内)だったのを修正。
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#812 と競合を生じたため、こちらにマージした。
fixed #810