Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

再インストール時「SMTP ホスト」等がグレーダウンしている #846 #847

Merged
merged 2 commits into from
Feb 26, 2024

Conversation

seasoftjapan
Copy link
Contributor

fixed #846

@seasoftjapan seasoftjapan added this to the 2.17.3 milestone Feb 21, 2024
@codecov-commenter
Copy link

codecov-commenter commented Feb 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (1346d10) 55.24% compared to head (a28c280) 55.24%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #847   +/-   ##
=======================================
  Coverage   55.24%   55.24%           
=======================================
  Files          75       75           
  Lines        8943     8943           
=======================================
  Hits         4941     4941           
  Misses       4002     4002           
Flag Coverage Δ
tests 55.24% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@nanasess nanasess left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nanasess
Copy link
Contributor

@seasoftjapan PHPStan が通るようになりましたので、最新の master を取り込んでいただいてよろしいでしょうか🙇‍♂️

@dotani1111 dotani1111 merged commit 30b11a1 into master Feb 26, 2024
4 checks passed
@seasoftjapan seasoftjapan deleted the seasoft-846 branch May 29, 2024 03:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

再インストール時「SMTP ホスト」等がグレーダウンしている
4 participants