Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use fakerphp/faker #880

Merged
merged 8 commits into from
Apr 16, 2024
Merged

Use fakerphp/faker #880

merged 8 commits into from
Apr 16, 2024

Conversation

nanasess
Copy link
Contributor

@nanasess nanasess commented Apr 5, 2024

fzaninotto/faker は非推奨なので fakerphp/faker を使用する

@nanasess nanasess enabled auto-merge April 5, 2024 01:08
@codecov-commenter
Copy link

codecov-commenter commented Apr 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.20%. Comparing base (eba815a) to head (a7a1d00).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #880   +/-   ##
=======================================
  Coverage   55.20%   55.20%           
=======================================
  Files          75       75           
  Lines        8900     8900           
=======================================
  Hits         4913     4913           
  Misses       3987     3987           
Flag Coverage Δ
tests 55.20% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nanasess nanasess merged commit 70bf51f into EC-CUBE:master Apr 16, 2024
91 checks passed
@nanasess nanasess deleted the use-php-faker branch April 16, 2024 00:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants