Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eccube install.sh エラー対応 #940

Merged
merged 2 commits into from
Jun 12, 2024

Conversation

seasoftjapan
Copy link
Contributor

コミットメッセージに記載の他、データベース eccube_db が存在しないケースのエラー回避も含んでいる。

Copy link

codecov bot commented Jun 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.69%. Comparing base (064a726) to head (83d7072).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #940   +/-   ##
=======================================
  Coverage   55.69%   55.69%           
=======================================
  Files          75       75           
  Lines        8905     8905           
=======================================
  Hits         4960     4960           
  Misses       3945     3945           
Flag Coverage Δ
tests 55.69% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@nanasess nanasess left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@seasoftjapan seasoftjapan merged commit 052b47e into EC-CUBE:master Jun 12, 2024
90 checks passed
@seasoftjapan seasoftjapan deleted the 20240612-eccube_install.sh branch July 24, 2024 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants