Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

テンプレート設定 登録時の致命的エラーを修正 #978

Merged
merged 1 commit into from
Aug 17, 2024

Conversation

clicktx
Copy link
Contributor

@clicktx clicktx commented Aug 17, 2024

Smartyのメソッド名が変更されているため、登録時に致命的エラーとなります。

Copy link

codecov bot commented Aug 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.63%. Comparing base (988c9bd) to head (589debd).
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #978   +/-   ##
=======================================
  Coverage   55.63%   55.63%           
=======================================
  Files          75       75           
  Lines        8917     8917           
=======================================
  Hits         4961     4961           
  Misses       3956     3956           
Flag Coverage Δ
tests 55.63% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@seasoftjapan seasoftjapan changed the title テンプレート登録時の致命的エラーを修正 テンプレート設定 登録時の致命的エラーを修正 Aug 17, 2024
Copy link
Contributor

@seasoftjapan seasoftjapan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR適用前後で、エラーの発生と解消を確認しました。

Copy link
Contributor

@nanasess nanasess left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nanasess nanasess merged commit 13d37b8 into EC-CUBE:master Aug 17, 2024
90 checks passed
@clicktx clicktx deleted the fix/admin-design-template branch September 29, 2024 01:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants