feat: Update DMS provider to expect multiple sortable properties. #343
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moonscape09
force-pushed
the
dms-multiple-sortable-properties
branch
3 times, most recently
from
4bf06c2
to
a87b25f
Compare
moonscape09
force-pushed
the
dms-multiple-sortable-properties
branch
from
a87b25f
to
a76f89f
Compare
The `sortby` mechanism in the query method has been updated to expect sortable properties in a collection rather than as a single item, enabling multiple sortable properties. This has been done by adding a new `sortables` list member to the `MSCDMSCoreAPIProvider` class. This attribute is set to a `sortables` definition if it exists as a list in `msc-pygeoapi-config.yml`. Otherwise, it stores just the `time_field`.
moonscape09
force-pushed
the
dms-multiple-sortable-properties
branch
from
a76f89f
to
1a89e46
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
sortbymechanism in the query method has been updated to expect sortable properties in a collection rather than as a single item, enabling multiple sortable properties. This has been done by adding a newsortableslist member to theMSCDMSCoreAPIProviderclass. This attribute is set to asortablesdefinition if it exists as a list inmsc-pygeoapi-config.yml. Otherwise, it stores just thetime_field.cc @kngai