Python: Errors & Linting #5124
Merged
Python: Errors & Linting #5124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ax3l
added
cleaning
ax3l
requested review from
dpgrote,
lucafedeli88,
RemiLehe,
JustinRayAngus and
EZoni
ax3l
commented
Aug 10, 2024
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -405,7 +407,7 @@ | |||
| ds_start = yt.load(filename_start) | |||
| ad_end = ds_end.all_data() | |||
| ad_start = ds_start.all_data() | |||
| dt = float(ds_end.current_time - ds_start.current_time) | |||
| dt = float(ds_end.current_time - ds_start.current_time) # noqa | |||
Check notice
Code scanning / CodeQL
Unused local variable Note
There was a problem hiding this comment.
@dpgrote wrote in #5123 (comment)
The
evalbelow needs dt. Theevalis kind of hacky anyway. Something like this would be betterif i == 1: specific_check1(data, dt) elif i == 2: specific_check2(data, dt)
There was a problem hiding this comment.
A simple fix would be to do
eval("specific_check"+str(i))(data, dt)
But it would be better to remove the eval altogether.
There was a problem hiding this comment.
Yes, that looks very similar to me 😅
ax3l
force-pushed
the
fix-python-linter
branch
2 times, most recently
from
21c1c83
to
e9ffd2a
Compare
ax3l
force-pushed
the
fix-python-linter
branch
2 times, most recently
from
8a9e3b1
to
06cb199
Compare
Add no-quality-assurance (noqa) annotations.
Removes unmaintained and outdated performance tests we ran on older HPC machines. We will reestablish something more maintainable with CTest and NESAP workflows through containers.
ax3l
force-pushed
the
fix-python-linter
branch
from
06cb199
to
1262ee6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying to fix a lot of errors so far in preparation of integrating Ruff in #5123.
Removes unmaintained and outdated performance tests we ran on older machines. We will reestablish something more maintainable with CTest and NESAP workflows through containers.
First badge of fixes, ready to go.