Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MPI Domain-Decomposition w/o Space Charge #503

Closed
ax3l opened this issue Jan 10, 2024 · 1 comment · Fixed by #504
Closed

MPI Domain-Decomposition w/o Space Charge #503

ax3l opened this issue Jan 10, 2024 · 1 comment · Fixed by #504
Assignees
Labels
bug: affects latest release Bug also exists in latest release version bug Something isn't working component: core Core ImpactX functionality

Comments

@ax3l
Copy link
Member

ax3l commented Jan 10, 2024

Yesterday, I realized that domain decomposition and load balancing with MPI is broken when space charge is not used. All particles end up on the same MPI rank now, causing load imbalance. Need to investigate.

Seems to show up as an issue for N>2 ranks or so, because on ResizeMesh we pad the beam by 3x vacuum by default for dynamic mesh resizes.

Related to #498, but likely earlier caused by #181 / #261 / #367 / #402.

@ax3l ax3l added bug Something isn't working bug: affects latest release Bug also exists in latest release version labels Jan 10, 2024
@ax3l ax3l added this to the Advanced Methods (SciDAC) milestone Jan 10, 2024
@ax3l ax3l added the component: core Core ImpactX functionality label Jan 10, 2024
@ax3l
Copy link
Member Author

ax3l commented Jan 10, 2024

I think in AmrCoreData::one_box_per_rank, we need to set the max_grid_size, if defaulted, to the blocking factor.

@ax3l ax3l self-assigned this Jan 10, 2024
@ax3l ax3l closed this as completed in #504 Jan 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug: affects latest release Bug also exists in latest release version bug Something isn't working component: core Core ImpactX functionality
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant